1
0
Fork 0

autofs: fix autofs4_fill_super() error exit handling

Somewhere along the line the error handling gotos have become incorrect.

Link: http://lkml.kernel.org/r/20160812024749.12352.15100.stgit@pluto.themaw.net
Signed-off-by: Ian Kent <raven@themaw.net>
Cc: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
steinar/wifi_calib_4_9_kernel
Ian Kent 2016-10-11 13:52:33 -07:00 committed by Linus Torvalds
parent 749800ef53
commit 1973a12269
1 changed files with 3 additions and 3 deletions

View File

@ -313,7 +313,7 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent)
if (!pipe) {
pr_err("could not open pipe file descriptor\n");
goto fail_dput;
goto fail_put_pid;
}
ret = autofs_prepare_pipe(pipe);
if (ret < 0)
@ -334,14 +334,14 @@ int autofs4_fill_super(struct super_block *s, void *data, int silent)
fail_fput:
pr_err("pipe file descriptor does not contain proper ops\n");
fput(pipe);
/* fall through */
fail_put_pid:
put_pid(sbi->oz_pgrp);
fail_dput:
dput(root);
goto fail_free;
fail_ino:
kfree(ino);
fail_free:
put_pid(sbi->oz_pgrp);
kfree(sbi);
s->s_fs_info = NULL;
return ret;