redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

[media] lirc_dev: simplify if statement in lirc_add_to_buf

Browse source 
The whole function is inside an 'if' statement
("if (ir->d.add_to_buf)").

Check the opposite of that statement at the beginning and exit,
this way we can have one level less of indentation.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Andi Shyti 2016-07-06 06:01:19 -03:00 committed by Mauro Carvalho Chehab
parent 7fe579d29f
commit 19e565397c
1 changed files with 15 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
drivers/media/rc/lirc_dev.c
View file

@ -97,26 +97,25 @@ static void lirc_irctl_cleanup(struct irctl *ir)
*/
static int lirc_add_to_buf(struct irctl *ir)
{
if (ir->d.add_to_buf) {
int res = -ENODATA;
int got_data = -1;
int res;
int got_data = -1;
/*
* service the device as long as it is returning
* data and we have space
*/
do {
got_data++;
res = ir->d.add_to_buf(ir->d.data, ir->buf);
} while (!res);
if (!ir->d.add_to_buf)
return 0;
if (res == -ENODEV)
kthread_stop(ir->task);
/*
* service the device as long as it is returning
* data and we have space
*/
do {
got_data++;
res = ir->d.add_to_buf(ir->d.data, ir->buf);
} while (!res);
return got_data ? 0 : res;
}
if (res == -ENODEV)
kthread_stop(ir->task);
return 0;
return got_data ? 0 : res;
}
/* main function of the polling thread