From 1bf1fea95ff9161fafccbcac76b37bbadc924bd0 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Fri, 9 Aug 2013 14:20:51 +0200 Subject: [PATCH] pinctrl: imx: Catch no fsl,pins property Instead of crashing the kernel print an error message when the fsl,pins property is missing. Signed-off-by: Sascha Hauer Acked-by: Shawn Guo Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-imx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c index f1be17f6fcf1..deeb740fa94e 100644 --- a/drivers/pinctrl/pinctrl-imx.c +++ b/drivers/pinctrl/pinctrl-imx.c @@ -456,6 +456,11 @@ static int imx_pinctrl_parse_groups(struct device_node *np, * do sanity check and calculate pins number */ list = of_get_property(np, "fsl,pins", &size); + if (!list) { + dev_err(info->dev, "no fsl,pins property in node %s\n", np->full_name); + return -EINVAL; + } + /* we do not check return since it's safe node passed down */ if (!size || size % pin_size) { dev_err(info->dev, "Invalid fsl,pins property in node %s\n", np->full_name);