redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

android: binder: Use octal permissions

Browse source 
checkpatch warns against the use of symbolic permissions,
this patch migrates all symbolic permissions in the binder
driver to octal permissions.

Test: debugfs nodes created by binder have the same unix
permissions prior to and after this patch was applied.

Signed-off-by: Harsh Shandilya <harsh@prjkt.io>
Cc: "Arve Hjønnevåg" <arve@android.com>
Cc: Todd Kjos <tkjos@android.com>
Cc: Martijn Coenen <maco@android.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Harsh Shandilya 2017-12-22 19:37:02 +05:30 committed by Greg Kroah-Hartman
parent 74d83a5d74
commit 21d02ddf71
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
drivers/android/binder.c
View file

@ -141,7 +141,7 @@ enum {
}; };
static uint32_t binder_debug_mask = BINDER_DEBUG_USER_ERROR | static uint32_t binder_debug_mask = BINDER_DEBUG_USER_ERROR |
BINDER_DEBUG_FAILED_TRANSACTION | BINDER_DEBUG_DEAD_TRANSACTION; BINDER_DEBUG_FAILED_TRANSACTION | BINDER_DEBUG_DEAD_TRANSACTION;
module_param_named(debug_mask, binder_debug_mask, uint, S_IWUSR | S_IRUGO); module_param_named(debug_mask, binder_debug_mask, uint, 0644);
static char *binder_devices_param = CONFIG_ANDROID_BINDER_DEVICES; static char *binder_devices_param = CONFIG_ANDROID_BINDER_DEVICES;
module_param_named(devices, binder_devices_param, charp, 0444); module_param_named(devices, binder_devices_param, charp, 0444);
@ -160,7 +160,7 @@ static int binder_set_stop_on_user_error(const char *val,
return ret; return ret;
} }
module_param_call(stop_on_user_error, binder_set_stop_on_user_error, module_param_call(stop_on_user_error, binder_set_stop_on_user_error,
param_get_int, &binder_stop_on_user_error, S_IWUSR | S_IRUGO); param_get_int, &binder_stop_on_user_error, 0644);
#define binder_debug(mask, x...) \ #define binder_debug(mask, x...) \
do { \ do { \
@ -4767,7 +4767,7 @@ static int binder_open(struct inode *nodp, struct file *filp)
* anyway print all contexts that a given PID has, so this * anyway print all contexts that a given PID has, so this
* is not a problem. * is not a problem.
*/ */
proc->debugfs_entry = debugfs_create_file(strbuf, S_IRUGO, proc->debugfs_entry = debugfs_create_file(strbuf, 0444,
binder_debugfs_dir_entry_proc, binder_debugfs_dir_entry_proc,
(void *)(unsigned long)proc->pid, (void *)(unsigned long)proc->pid,
&binder_proc_fops); &binder_proc_fops);
@ -5610,27 +5610,27 @@ static int __init binder_init(void)
if (binder_debugfs_dir_entry_root) { if (binder_debugfs_dir_entry_root) {
debugfs_create_file("state", debugfs_create_file("state",
S_IRUGO, 0444,
binder_debugfs_dir_entry_root, binder_debugfs_dir_entry_root,
NULL, NULL,
&binder_state_fops); &binder_state_fops);
debugfs_create_file("stats", debugfs_create_file("stats",
S_IRUGO, 0444,
binder_debugfs_dir_entry_root, binder_debugfs_dir_entry_root,
NULL, NULL,
&binder_stats_fops); &binder_stats_fops);
debugfs_create_file("transactions", debugfs_create_file("transactions",
S_IRUGO, 0444,
binder_debugfs_dir_entry_root, binder_debugfs_dir_entry_root,
NULL, NULL,
&binder_transactions_fops); &binder_transactions_fops);
debugfs_create_file("transaction_log", debugfs_create_file("transaction_log",
S_IRUGO, 0444,
binder_debugfs_dir_entry_root, binder_debugfs_dir_entry_root,
&binder_transaction_log, &binder_transaction_log,
&binder_transaction_log_fops); &binder_transaction_log_fops);
debugfs_create_file("failed_transaction_log", debugfs_create_file("failed_transaction_log",
S_IRUGO, 0444,
binder_debugfs_dir_entry_root, binder_debugfs_dir_entry_root,
&binder_transaction_log_failed, &binder_transaction_log_failed,
&binder_transaction_log_fops); &binder_transaction_log_fops);