redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

mfd: ab8500-debug: Better error handling on crash

Browse source 
Stop trying to read i2c registers if one fail.

Signed-off-by: Jonas Aaberg <jonas.aberg@stericsson.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Mattias WALLIN <mattias.wallin@stericsson.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Jonas Aaberg 2012-06-18 10:35:28 +02:00 committed by Lee Jones
parent 3e1a498f27
commit 222460cb4b
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/mfd/ab8500-debugfs.c
View file

@ -608,7 +608,6 @@ struct ab8500_register_dump
u8 bank;
u8 reg;
u8 value;
int ret;
} ab8500_complete_register_dump[DUMP_MAX_REGS];
extern int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size);
@ -618,6 +617,7 @@ void ab8500_dump_all_banks_to_mem(void)
{
int i, r = 0;
u8 bank;
int err = 0;
pr_info("Saving all ABB registers at \"ab8500_complete_register_dump\" "
"for crash analyze.\n");
@ -630,11 +630,12 @@ void ab8500_dump_all_banks_to_mem(void)
reg <= debug_ranges[bank].range[i].last;
reg++) {
u8 value;
int err;
err = prcmu_abb_read(bank, reg, &value, 1);
ab8500_complete_register_dump[r].ret = err;
if (err < 0)
goto out;
ab8500_complete_register_dump[r].bank = bank;
ab8500_complete_register_dump[r].reg = reg;
ab8500_complete_register_dump[r].value = value;
@ -644,11 +645,17 @@ void ab8500_dump_all_banks_to_mem(void)
if (r >= DUMP_MAX_REGS) {
pr_err("%s: too many register to dump!\n",
__func__);
return;
err = -EINVAL;
goto out;
}
}
}
}
out:
if (err >= 0)
pr_info("Saved all ABB registers.\n");
else
pr_info("Failed to save all ABB registers.\n");
}
static int ab8500_all_banks_open(struct inode *inode, struct file *file)