redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

MLK-20220 staging: typec: tcpci: fix improper use of negative value 

Coverity complains CID 3411292: Improper use of negative valure
(NEGATIVE_RETURNS), as possibly assign a negative value to unsigned
int, fix it by use an int temp value for negative value return.

Acked-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
(cherry picked from commit 9ab72e25fcda73a455a434993c8186663c241f27)
pull/10/head
Li Jun 2018-11-13 16:37:42 +08:00
parent 76715b9c79
commit 2273e2dcd9
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/staging/typec/tcpci.c
View File

@ -662,13 +662,14 @@ static int tcpci_parse_config(struct tcpci *tcpci)
goto sink;
/* Check source pdo array size */
tcfg->nr_src_pdo = device_property_read_u32_array(tcpci->dev,
"src-pdos", NULL, 0);
if (tcfg->nr_src_pdo <= 0) {
ret = device_property_read_u32_array(tcpci->dev, "src-pdos", NULL, 0);
if (ret <= 0) {
dev_err(tcpci->dev, "typec source pdo is missing!\n");
return -EINVAL;
}
tcfg->nr_src_pdo = ret;
/* Alloc src_pdo based on the array size */
tcfg->src_pdo = devm_kzalloc(tcpci->dev,
sizeof(*tcfg->src_pdo) * tcfg->nr_src_pdo, GFP_KERNEL);
@ -728,13 +729,15 @@ static int tcpci_parse_config(struct tcpci *tcpci)
sink:
/* Check the num of snk pdo */
tcfg->nr_snk_pdo = device_property_read_u32_array(tcpci->dev,
"snk-pdos", NULL, 0);
if (tcfg->nr_snk_pdo <= 0) {
ret = device_property_read_u32_array(tcpci->dev,
"snk-pdos", NULL, 0);
if (ret <= 0) {
dev_err(tcpci->dev, "typec sink pdo is missing!\n");
return -EINVAL;
}
tcfg->nr_snk_pdo = ret;
/* alloc snk_pdo based on the array size */
tcfg->snk_pdo = devm_kzalloc(tcpci->dev,
sizeof(*tcfg->snk_pdo) * tcfg->nr_snk_pdo, GFP_KERNEL);