watchdog: rza_wdt: Use 'dev' instead of dereferencing it repeatedly
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
This commit is contained in:
parent
553140a016
commit
2361ac5289
|
@ -166,11 +166,12 @@ static const struct watchdog_ops rza_wdt_ops = {
|
|||
|
||||
static int rza_wdt_probe(struct platform_device *pdev)
|
||||
{
|
||||
struct device *dev = &pdev->dev;
|
||||
struct rza_wdt *priv;
|
||||
unsigned long rate;
|
||||
int ret;
|
||||
|
||||
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
|
||||
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
|
||||
if (!priv)
|
||||
return -ENOMEM;
|
||||
|
||||
|
@ -178,21 +179,21 @@ static int rza_wdt_probe(struct platform_device *pdev)
|
|||
if (IS_ERR(priv->base))
|
||||
return PTR_ERR(priv->base);
|
||||
|
||||
priv->clk = devm_clk_get(&pdev->dev, NULL);
|
||||
priv->clk = devm_clk_get(dev, NULL);
|
||||
if (IS_ERR(priv->clk))
|
||||
return PTR_ERR(priv->clk);
|
||||
|
||||
rate = clk_get_rate(priv->clk);
|
||||
if (rate < 16384) {
|
||||
dev_err(&pdev->dev, "invalid clock rate (%ld)\n", rate);
|
||||
dev_err(dev, "invalid clock rate (%ld)\n", rate);
|
||||
return -ENOENT;
|
||||
}
|
||||
|
||||
priv->wdev.info = &rza_wdt_ident,
|
||||
priv->wdev.ops = &rza_wdt_ops,
|
||||
priv->wdev.parent = &pdev->dev;
|
||||
priv->wdev.parent = dev;
|
||||
|
||||
priv->cks = (u8)(uintptr_t)of_device_get_match_data(&pdev->dev);
|
||||
priv->cks = (u8)(uintptr_t) of_device_get_match_data(dev);
|
||||
if (priv->cks == CKS_4BIT) {
|
||||
/* Assume slowest clock rate possible (CKS=0xF) */
|
||||
priv->wdev.max_timeout = (DIVIDER_4BIT * U8_MAX) / rate;
|
||||
|
@ -207,19 +208,19 @@ static int rza_wdt_probe(struct platform_device *pdev)
|
|||
* max_hw_heartbeat_ms.
|
||||
*/
|
||||
priv->wdev.max_hw_heartbeat_ms = (1000 * U8_MAX) / rate;
|
||||
dev_dbg(&pdev->dev, "max hw timeout of %dms\n",
|
||||
priv->wdev.max_hw_heartbeat_ms);
|
||||
dev_dbg(dev, "max hw timeout of %dms\n",
|
||||
priv->wdev.max_hw_heartbeat_ms);
|
||||
}
|
||||
|
||||
priv->wdev.min_timeout = 1;
|
||||
priv->wdev.timeout = DEFAULT_TIMEOUT;
|
||||
|
||||
watchdog_init_timeout(&priv->wdev, 0, &pdev->dev);
|
||||
watchdog_init_timeout(&priv->wdev, 0, dev);
|
||||
watchdog_set_drvdata(&priv->wdev, priv);
|
||||
|
||||
ret = devm_watchdog_register_device(&pdev->dev, &priv->wdev);
|
||||
ret = devm_watchdog_register_device(dev, &priv->wdev);
|
||||
if (ret)
|
||||
dev_err(&pdev->dev, "Cannot register watchdog device\n");
|
||||
dev_err(dev, "Cannot register watchdog device\n");
|
||||
|
||||
return ret;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue