ceph: refactor readpage_nounlock() to make the logic clearer
If the return value of ceph_osdc_readpages() is not negative, it is certainly greater than or equal to zero. Remove the useless condition judgment and redundant braces. Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> Reviewed-by: Yan, Zheng <zheng.z.yan@intel.com>
This commit is contained in:
parent
ca665e0282
commit
23cd573b46
|
@ -211,18 +211,15 @@ static int readpage_nounlock(struct file *filp, struct page *page)
|
|||
SetPageError(page);
|
||||
ceph_fscache_readpage_cancel(inode, page);
|
||||
goto out;
|
||||
} else {
|
||||
if (err < PAGE_CACHE_SIZE) {
|
||||
/* zero fill remainder of page */
|
||||
zero_user_segment(page, err, PAGE_CACHE_SIZE);
|
||||
} else {
|
||||
flush_dcache_page(page);
|
||||
}
|
||||
}
|
||||
SetPageUptodate(page);
|
||||
if (err < PAGE_CACHE_SIZE)
|
||||
/* zero fill remainder of page */
|
||||
zero_user_segment(page, err, PAGE_CACHE_SIZE);
|
||||
else
|
||||
flush_dcache_page(page);
|
||||
|
||||
if (err >= 0)
|
||||
ceph_readpage_to_fscache(inode, page);
|
||||
SetPageUptodate(page);
|
||||
ceph_readpage_to_fscache(inode, page);
|
||||
|
||||
out:
|
||||
return err < 0 ? err : 0;
|
||||
|
|
Loading…
Reference in a new issue