scsi: bfa: fix type conversion warning
commitpull/10/head48d83282db
upstream. A regression fix introduced a harmless type mismatch warning: drivers/scsi/bfa/bfad_bsg.c: In function 'bfad_im_bsg_vendor_request': drivers/scsi/bfa/bfad_bsg.c:3137:35: error: initialization of 'struct bfad_im_port_s *' from 'long unsigned int' makes pointer from integer without a cast [-Werror=int-conversion] struct bfad_im_port_s *im_port = shost->hostdata[0]; ^~~~~ drivers/scsi/bfa/bfad_bsg.c: In function 'bfad_im_bsg_els_ct_request': drivers/scsi/bfa/bfad_bsg.c:3353:35: error: initialization of 'struct bfad_im_port_s *' from 'long unsigned int' makes pointer from integer without a cast [-Werror=int-conversion] struct bfad_im_port_s *im_port = shost->hostdata[0]; This changes the code back to shost_priv() once more, but encapsulates it in an inline function to document the rather unusual way of using the private data only as a pointer to the previously allocated structure. I did not try to get rid of the extra indirection level entirely, which would have been rather invasive and required reworking the entire initialization sequence. Fixes:45349821ab
("scsi: bfa: fix access to bfad_im_port_s") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Reviewed-by: Hannes Reinecke <hare@suse.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Cc: Sasha Levin <Alexander.Levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
e748a5ea4f
commit
249d9f3ef5
|
@ -3136,7 +3136,7 @@ bfad_im_bsg_vendor_request(struct bsg_job *job)
|
|||
struct fc_bsg_reply *bsg_reply = job->reply;
|
||||
uint32_t vendor_cmd = bsg_request->rqst_data.h_vendor.vendor_cmd[0];
|
||||
struct Scsi_Host *shost = fc_bsg_to_shost(job);
|
||||
struct bfad_im_port_s *im_port = shost->hostdata[0];
|
||||
struct bfad_im_port_s *im_port = bfad_get_im_port(shost);
|
||||
struct bfad_s *bfad = im_port->bfad;
|
||||
struct request_queue *request_q = job->req->q;
|
||||
void *payload_kbuf;
|
||||
|
@ -3359,7 +3359,7 @@ bfad_im_bsg_els_ct_request(struct bsg_job *job)
|
|||
{
|
||||
struct bfa_bsg_data *bsg_data;
|
||||
struct Scsi_Host *shost = fc_bsg_to_shost(job);
|
||||
struct bfad_im_port_s *im_port = shost->hostdata[0];
|
||||
struct bfad_im_port_s *im_port = bfad_get_im_port(shost);
|
||||
struct bfad_s *bfad = im_port->bfad;
|
||||
bfa_bsg_fcpt_t *bsg_fcpt;
|
||||
struct bfad_fcxp *drv_fcxp;
|
||||
|
|
|
@ -546,6 +546,7 @@ int
|
|||
bfad_im_scsi_host_alloc(struct bfad_s *bfad, struct bfad_im_port_s *im_port,
|
||||
struct device *dev)
|
||||
{
|
||||
struct bfad_im_port_pointer *im_portp;
|
||||
int error = 1;
|
||||
|
||||
mutex_lock(&bfad_mutex);
|
||||
|
@ -564,7 +565,8 @@ bfad_im_scsi_host_alloc(struct bfad_s *bfad, struct bfad_im_port_s *im_port,
|
|||
goto out_free_idr;
|
||||
}
|
||||
|
||||
im_port->shost->hostdata[0] = (unsigned long)im_port;
|
||||
im_portp = shost_priv(im_port->shost);
|
||||
im_portp->p = im_port;
|
||||
im_port->shost->unique_id = im_port->idr_id;
|
||||
im_port->shost->this_id = -1;
|
||||
im_port->shost->max_id = MAX_FCP_TARGET;
|
||||
|
@ -748,7 +750,7 @@ bfad_scsi_host_alloc(struct bfad_im_port_s *im_port, struct bfad_s *bfad)
|
|||
|
||||
sht->sg_tablesize = bfad->cfg_data.io_max_sge;
|
||||
|
||||
return scsi_host_alloc(sht, sizeof(unsigned long));
|
||||
return scsi_host_alloc(sht, sizeof(struct bfad_im_port_pointer));
|
||||
}
|
||||
|
||||
void
|
||||
|
|
|
@ -69,6 +69,16 @@ struct bfad_im_port_s {
|
|||
struct fc_vport *fc_vport;
|
||||
};
|
||||
|
||||
struct bfad_im_port_pointer {
|
||||
struct bfad_im_port_s *p;
|
||||
};
|
||||
|
||||
static inline struct bfad_im_port_s *bfad_get_im_port(struct Scsi_Host *host)
|
||||
{
|
||||
struct bfad_im_port_pointer *im_portp = shost_priv(host);
|
||||
return im_portp->p;
|
||||
}
|
||||
|
||||
enum bfad_itnim_state {
|
||||
ITNIM_STATE_NONE,
|
||||
ITNIM_STATE_ONLINE,
|
||||
|
|
Loading…
Reference in New Issue