redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

net/hsr: Remove left-over never-true conditional code. 

MacAddressB is an array (unsigned char MacAddressB[ETH_ALEN]) and is allocated
as a part of *node_dst (which is a struct hsr_node). So the condition is always
false.

Detected by Dan Carpenter.

Signed-off-by: Arvid Brodin <arvid.brodin@alten.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
wifi-calibration
Arvid Brodin 2014-07-11 18:21:12 +02:00 committed by David S. Miller
parent 19278cab62
commit 279f64b7a7
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/hsr/hsr_framereg.c
View File

@ -290,10 +290,6 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb,
}
if (port->type != node_dst->AddrB_port)
return;
if (!node_dst->MacAddressB) {
WARN_ONCE(1, "%s: No MacAddressB\n", __func__);
return;
}
ether_addr_copy(eth_hdr(skb)->h_dest, node_dst->MacAddressB);
}