redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

serial: vt8500: Fix range-checking on vt8500_uart_ports

Browse source 
Fix two instances where the index to vt8500_uart_ports is tested
against > VT8500_MAX_PORTS. Correct usage should be >= VT8500_MAX_PORTS.

Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Tony Prisk 2013-01-17 08:05:40 +13:00 committed by Greg Kroah-Hartman
parent f938f3781f
commit 27dd2e0492
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/tty/serial/vt8500_serial.c
View file

@ -560,7 +560,7 @@ static int vt8500_serial_probe(struct platform_device *pdev)
if (np)
port = of_alias_get_id(np, "serial");
if (port > VT8500_MAX_PORTS)
if (port >= VT8500_MAX_PORTS)
port = -1;
else
port = -1;
@ -571,7 +571,7 @@ static int vt8500_serial_probe(struct platform_device *pdev)
sizeof(vt8500_ports_in_use));
}
if (port > VT8500_MAX_PORTS)
if (port >= VT8500_MAX_PORTS)
return -ENODEV;
/* reserve the port id */