redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

[media] s5p-fimc: add unlock on error path

Browse source 
There was an unlock missing if kzalloc() failed.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Dan Carpenter 2010-10-21 16:22:43 -03:00 committed by Mauro Carvalho Chehab
parent aa55f3a46f
commit 29adc2c06f
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/media/video/s5p-fimc/fimc-core.c
View file

@ -1320,16 +1320,18 @@ static int fimc_m2m_open(struct file *file)
* is already opened.
*/
if (fimc->vid_cap.refcnt > 0) {
mutex_unlock(&fimc->lock);
return -EBUSY;
err = -EBUSY;
goto err_unlock;
}
fimc->m2m.refcnt++;
set_bit(ST_OUTDMA_RUN, &fimc->state);
ctx = kzalloc(sizeof *ctx, GFP_KERNEL);
if (!ctx)
return -ENOMEM;
if (!ctx) {
err = -ENOMEM;
goto err_unlock;
}
file->private_data = ctx;
ctx->fimc_dev = fimc;
@ -1349,6 +1351,7 @@ static int fimc_m2m_open(struct file *file)
kfree(ctx);
}
err_unlock:
mutex_unlock(&fimc->lock);
return err;
}