redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

NFC: nci: Fix error check of nci_hci_create_pipe() result

Browse source 
net/nfc/nci/hci.c: In function nci_hci_connect_gate :
net/nfc/nci/hci.c:679: warning: comparison is always false due to limited range of data type

In case of error, nci_hci_create_pipe() returns NCI_HCI_INVALID_PIPE,
and not a negative error code.

Correct the check to fix this.

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
Christophe Ricard 2015-12-23 23:45:15 +01:00 committed by Samuel Ortiz
parent 4940d1c355
commit 2a84193f14
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/nfc/nci/hci.c
View file

@ -676,7 +676,7 @@ int nci_hci_connect_gate(struct nci_dev *ndev,
break; break;
default: default:
pipe = nci_hci_create_pipe(ndev, dest_host, dest_gate, &r); pipe = nci_hci_create_pipe(ndev, dest_host, dest_gate, &r);
if (pipe < 0) if (pipe == NCI_HCI_INVALID_PIPE)
return r; return r;
pipe_created = true; pipe_created = true;
break; break;