1
0
Fork 0

Staging: Correct use of ! and &

Correct priority problem in the use of ! and &.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E; constant C; @@
- !E & C
+ !(E & C)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
wifi-calibration
Julia Lawall 2009-07-27 21:59:48 +02:00 committed by Greg Kroah-Hartman
parent 658ce9d653
commit 2e9ab1e72c
2 changed files with 3 additions and 6 deletions

View File

@ -1840,10 +1840,8 @@ int rt_ioctl_siwencode(struct net_device *dev,
}
else
/* Don't complain if only change the mode */
if(!erq->flags & IW_ENCODE_MODE)
{
return -EINVAL;
}
if (!(erq->flags & IW_ENCODE_MODE))
return -EINVAL;
}
done:

View File

@ -1409,8 +1409,7 @@ int iwctl_siwencode(struct net_device *dev,
// Do we want to just set the transmit key index ?
if ( index < 4 ) {
pDevice->byKeyIndex = index;
}
else if(!wrq->flags & IW_ENCODE_MODE) {
} else if (!(wrq->flags & IW_ENCODE_MODE)) {
rc = -EINVAL;
return rc;
}