redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

trace_stack: Simplify seqfile code

Browse source 
Extract duplicate code in t_start() and t_next().

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <4A891A91.4030602@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Li Zefan 2009-08-17 16:53:37 +08:00 committed by Ingo Molnar
parent 97d53202a5
commit 2fc5f0cff4
1 changed files with 12 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
kernel/trace/trace_stack.c
View file

@ -186,43 +186,33 @@ static const struct file_operations stack_max_size_fops = {
}; };
static void * static void *
t_next(struct seq_file *m, void *v, loff_t *pos) __next(struct seq_file *m, loff_t *pos)
{ {
long i; long n = *pos - 1;
(*pos)++; if (n >= max_stack_trace.nr_entries || stack_dump_trace[n] == ULONG_MAX)
if (v == SEQ_START_TOKEN)
i = 0;
else {
i = *(long *)v;
i++;
}
if (i >= max_stack_trace.nr_entries ||
stack_dump_trace[i] == ULONG_MAX)
return NULL; return NULL;
m->private = (void *)i; m->private = (void *)n;
return &m->private; return &m->private;
} }
static void *
t_next(struct seq_file *m, void *v, loff_t *pos)
{
(*pos)++;
return __next(m, pos);
}
static void *t_start(struct seq_file *m, loff_t *pos) static void *t_start(struct seq_file *m, loff_t *pos)
{ {
void *t = SEQ_START_TOKEN;
loff_t l = 0;
local_irq_disable(); local_irq_disable();
__raw_spin_lock(&max_stack_lock); __raw_spin_lock(&max_stack_lock);
if (*pos == 0) if (*pos == 0)
return SEQ_START_TOKEN; return SEQ_START_TOKEN;
for (; t && l < *pos; t = t_next(m, t, &l)) return __next(m, pos);
;
return t;
} }
static void t_stop(struct seq_file *m, void *p) static void t_stop(struct seq_file *m, void *p)