redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

IB/qib: Fix module-level leak

Browse source 
The vzalloc()'ed field physshadow is leaked on module unload.

This patch adds vfree after the sibling page shadow is freed.

Reported-by: Dean Luick <dean.luick@intel.com>
Reviewed-by: Dean Luick <dean.luick@intel.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
This commit is contained in:
Mike Marciniszyn 2013-07-03 13:50:28 -04:00 committed by Roland Dreier
parent 22baa407f9
commit 308c813b19
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/infiniband/hw/qib/qib_init.c
View file

@ -1350,7 +1350,7 @@ static void cleanup_device_data(struct qib_devdata *dd)
if (dd->pageshadow) { if (dd->pageshadow) {
struct page **tmpp = dd->pageshadow; struct page **tmpp = dd->pageshadow;
dma_addr_t *tmpd = dd->physshadow; dma_addr_t *tmpd = dd->physshadow;
int i, cnt = 0; int i;
for (ctxt = 0; ctxt < dd->cfgctxts; ctxt++) { for (ctxt = 0; ctxt < dd->cfgctxts; ctxt++) {
int ctxt_tidbase = ctxt * dd->rcvtidcnt; int ctxt_tidbase = ctxt * dd->rcvtidcnt;
@ -1363,13 +1363,13 @@ static void cleanup_device_data(struct qib_devdata *dd)
PAGE_SIZE, PCI_DMA_FROMDEVICE); PAGE_SIZE, PCI_DMA_FROMDEVICE);
qib_release_user_pages(&tmpp[i], 1); qib_release_user_pages(&tmpp[i], 1);
tmpp[i] = NULL; tmpp[i] = NULL;
cnt++;
} }
} }
tmpp = dd->pageshadow;
dd->pageshadow = NULL; dd->pageshadow = NULL;
vfree(tmpp); vfree(tmpp);
dd->physshadow = NULL;
vfree(tmpd);
} }
/* /*