redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

ALSA: usb: constify snd_pcm_ops structures 

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
zero-colors
Arvind Yadav 2017-08-18 13:15:21 +05:30 committed by Takashi Iwai
parent 7a205f5db5
commit 31cb1fb41d
7 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/usb/6fire/pcm.c
View File

@ -555,7 +555,7 @@ static snd_pcm_uframes_t usb6fire_pcm_pointer(
return ret; return ret;
} }
static struct snd_pcm_ops pcm_ops = { static const struct snd_pcm_ops pcm_ops = {
.open = usb6fire_pcm_open, .open = usb6fire_pcm_open,
.close = usb6fire_pcm_close, .close = usb6fire_pcm_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,

2
sound/usb/caiaq/audio.c
View File

@ -338,7 +338,7 @@ unlock:
} }
/* operators for both playback and capture */ /* operators for both playback and capture */
static struct snd_pcm_ops snd_usb_caiaq_ops = { static const struct snd_pcm_ops snd_usb_caiaq_ops = {
.open = snd_usb_caiaq_substream_open, .open = snd_usb_caiaq_substream_open,
.close = snd_usb_caiaq_substream_close, .close = snd_usb_caiaq_substream_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,

2
sound/usb/hiface/pcm.c
View File

@ -513,7 +513,7 @@ static snd_pcm_uframes_t hiface_pcm_pointer(struct snd_pcm_substream *alsa_sub)
return bytes_to_frames(alsa_sub->runtime, dma_offset); return bytes_to_frames(alsa_sub->runtime, dma_offset);
} }
static struct snd_pcm_ops pcm_ops = { static const struct snd_pcm_ops pcm_ops = {
.open = hiface_pcm_open, .open = hiface_pcm_open,
.close = hiface_pcm_close, .close = hiface_pcm_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,

4
sound/usb/misc/ua101.c
View File

@ -890,7 +890,7 @@ static snd_pcm_uframes_t playback_pcm_pointer(struct snd_pcm_substream *subs)
return ua101_pcm_pointer(ua, &ua->playback); return ua101_pcm_pointer(ua, &ua->playback);
} }
static struct snd_pcm_ops capture_pcm_ops = { static const struct snd_pcm_ops capture_pcm_ops = {
.open = capture_pcm_open, .open = capture_pcm_open,
.close = capture_pcm_close, .close = capture_pcm_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,
@ -903,7 +903,7 @@ static struct snd_pcm_ops capture_pcm_ops = {
.mmap = snd_pcm_lib_mmap_vmalloc, .mmap = snd_pcm_lib_mmap_vmalloc,
}; };
static struct snd_pcm_ops playback_pcm_ops = { static const struct snd_pcm_ops playback_pcm_ops = {
.open = playback_pcm_open, .open = playback_pcm_open,
.close = playback_pcm_close, .close = playback_pcm_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,

4
sound/usb/pcm.c
View File

@ -1690,7 +1690,7 @@ static int snd_usb_substream_capture_trigger(struct snd_pcm_substream *substream
return -EINVAL; return -EINVAL;
} }
static struct snd_pcm_ops snd_usb_playback_ops = { static const struct snd_pcm_ops snd_usb_playback_ops = {
.open = snd_usb_playback_open, .open = snd_usb_playback_open,
.close = snd_usb_playback_close, .close = snd_usb_playback_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,
@ -1703,7 +1703,7 @@ static struct snd_pcm_ops snd_usb_playback_ops = {
.mmap = snd_pcm_lib_mmap_vmalloc, .mmap = snd_pcm_lib_mmap_vmalloc,
}; };
static struct snd_pcm_ops snd_usb_capture_ops = { static const struct snd_pcm_ops snd_usb_capture_ops = {
.open = snd_usb_capture_open, .open = snd_usb_capture_open,
.close = snd_usb_capture_close, .close = snd_usb_capture_close,
.ioctl = snd_pcm_lib_ioctl, .ioctl = snd_pcm_lib_ioctl,

2
sound/usb/usx2y/usbusx2yaudio.c
View File

@ -905,7 +905,7 @@ static int snd_usX2Y_pcm_close(struct snd_pcm_substream *substream)
} }
static struct snd_pcm_ops snd_usX2Y_pcm_ops = static const struct snd_pcm_ops snd_usX2Y_pcm_ops =
{ {
.open = snd_usX2Y_pcm_open, .open = snd_usX2Y_pcm_open,
.close = snd_usX2Y_pcm_close, .close = snd_usX2Y_pcm_close,

2
sound/usb/usx2y/usx2yhwdeppcm.c
View File

@ -587,7 +587,7 @@ static int snd_usX2Y_usbpcm_close(struct snd_pcm_substream *substream)
} }
static struct snd_pcm_ops snd_usX2Y_usbpcm_ops = static const struct snd_pcm_ops snd_usX2Y_usbpcm_ops =
{ {
.open = snd_usX2Y_usbpcm_open, .open = snd_usX2Y_usbpcm_open,
.close = snd_usX2Y_usbpcm_close, .close = snd_usX2Y_usbpcm_close,