misc: Fix irq leak in max8997_muic_probe error path
Current code does not properly free allocated irqs if request_threaded_irq returns error, fix it. Signed-off-by: Axel Lin <axel.lin@gmail.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
e816b57a33
commit
3241d56edd
|
@ -440,10 +440,6 @@ static int __devinit max8997_muic_probe(struct platform_device *pdev)
|
||||||
"failed: irq request (IRQ: %d,"
|
"failed: irq request (IRQ: %d,"
|
||||||
" error :%d)\n",
|
" error :%d)\n",
|
||||||
muic_irq->irq, ret);
|
muic_irq->irq, ret);
|
||||||
|
|
||||||
for (i = i - 1; i >= 0; i--)
|
|
||||||
free_irq(muic_irq->irq, info);
|
|
||||||
|
|
||||||
goto err_irq;
|
goto err_irq;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -457,6 +453,8 @@ static int __devinit max8997_muic_probe(struct platform_device *pdev)
|
||||||
return ret;
|
return ret;
|
||||||
|
|
||||||
err_irq:
|
err_irq:
|
||||||
|
while (--i >= 0)
|
||||||
|
free_irq(pdata->irq_base + muic_irqs[i].irq, info);
|
||||||
err_pdata:
|
err_pdata:
|
||||||
kfree(info);
|
kfree(info);
|
||||||
err_kfree:
|
err_kfree:
|
||||||
|
|
Loading…
Reference in a new issue