redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

ARM: imx: cleanup otg_mode

Browse source 
Cleanup the code for the otg_mode command line param:
* Use the bool type as it applies here.
* Qualify otg_mode_host with __initdata since this variable is only used in this
  context.
* The __setup functions are not supposed to return a status code, but a boolean
  indicating whether the param has been handled. See obsolete_checksetup() in
  init/main.c.

Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
This commit is contained in:
Benoît Thébaudeau 2012-06-12 19:46:43 +02:00 committed by Sascha Hauer
parent cfaf025112
commit 33a264ddcd
11 changed files with 44 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
arch/arm/mach-imx/mach-cpuimx27.c
View file

@ -233,18 +233,18 @@ static const struct fsl_usb2_platform_data otg_device_pdata __initconst = {
.phy_mode = FSL_USB2_PHY_ULPI,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init eukrea_cpuimx27_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", eukrea_cpuimx27_otg_mode);

8
arch/arm/mach-imx/mach-cpuimx35.c
View file

@ -142,18 +142,18 @@ static const struct fsl_usb2_platform_data otg_device_pdata __initconst = {
.workaround = FLS_USB2_WORKAROUND_ENGCM09152,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init eukrea_cpuimx35_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", eukrea_cpuimx35_otg_mode);

8
arch/arm/mach-imx/mach-cpuimx51sd.c
View file

@ -218,18 +218,18 @@ static const struct mxc_usbh_platform_data usbh1_config __initconst = {
.portsc = MXC_EHCI_MODE_ULPI,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init eukrea_cpuimx51sd_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", eukrea_cpuimx51sd_otg_mode);

8
arch/arm/mach-imx/mach-eukrea_cpuimx25.c
View file

@ -109,18 +109,18 @@ static const struct fsl_usb2_platform_data otg_device_pdata __initconst = {
.workaround = FLS_USB2_WORKAROUND_ENGCM09152,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init eukrea_cpuimx25_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", eukrea_cpuimx25_otg_mode);

8
arch/arm/mach-imx/mach-mx27_3ds.c
View file

@ -241,18 +241,18 @@ static const struct fsl_usb2_platform_data otg_device_pdata __initconst = {
.phy_mode = FSL_USB2_PHY_ULPI,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init mx27_3ds_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", mx27_3ds_otg_mode);

8
arch/arm/mach-imx/mach-mx31_3ds.c
View file

@ -671,18 +671,18 @@ static const struct fsl_usb2_platform_data usbotg_pdata __initconst = {
.phy_mode = FSL_USB2_PHY_ULPI,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init mx31_3ds_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", mx31_3ds_otg_mode);

8
arch/arm/mach-imx/mach-mx35_3ds.c
View file

@ -540,18 +540,18 @@ static const struct mxc_usbh_platform_data usb_host_pdata __initconst = {
.portsc = MXC_EHCI_MODE_SERIAL,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init mx35_3ds_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", mx35_3ds_otg_mode);

8
arch/arm/mach-imx/mach-mx51_babbage.c
View file

@ -307,18 +307,18 @@ static const struct mxc_usbh_platform_data usbh1_config __initconst = {
.portsc = MXC_EHCI_MODE_ULPI,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init babbage_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", babbage_otg_mode);

8
arch/arm/mach-imx/mach-pca100.c
View file

@ -298,18 +298,18 @@ static const struct fsl_usb2_platform_data otg_device_pdata __initconst = {
.phy_mode = FSL_USB2_PHY_ULPI,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init pca100_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", pca100_otg_mode);

8
arch/arm/mach-imx/mach-pcm037.c
View file

@ -557,18 +557,18 @@ static const struct fsl_usb2_platform_data otg_device_pdata __initconst = {
.phy_mode = FSL_USB2_PHY_ULPI,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init pcm037_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", pcm037_otg_mode);

8
arch/arm/mach-imx/mach-pcm043.c
View file

@ -330,18 +330,18 @@ static const struct fsl_usb2_platform_data otg_device_pdata __initconst = {
.phy_mode = FSL_USB2_PHY_UTMI,
};
static int otg_mode_host;
static bool otg_mode_host __initdata;
static int __init pcm043_otg_mode(char *options)
{
if (!strcmp(options, "host"))
otg_mode_host = 1;
otg_mode_host = true;
else if (!strcmp(options, "device"))
otg_mode_host = 0;
otg_mode_host = false;
else
pr_info("otg_mode neither \"host\" nor \"device\". "
"Defaulting to device\n");
return 0;
return 1;
}
__setup("otg_mode=", pcm043_otg_mode);