redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

MLK-20181-3: drm/mxsfb: Add pm_runtime calls to pipe_enable/disable 

Adding lcdif nodes to a power domain currently results in
black/corrupted screens or hangs because power is not correctly enabled
when required.

Ensure power is on when display is active by adding
pm_runtime_get/put_sync to mxsfb_pipe_enable/disable.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Reviewed-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Stefan Agner <stefan@agner.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/ee88148399c63494cda4129b05444b0ac331b7a7.1537191359.git.leonard.crestez@nxp.com
pull/10/head
Leonard Crestez 2018-09-17 16:42:13 +03:00 committed by Robert Chiras
parent f83ab92705
commit 37526cc27b
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/drm/mxsfb/mxsfb_drv.c
View File

@ -191,16 +191,17 @@ static void mxsfb_pipe_enable(struct drm_simple_display_pipe *pipe,
drm_crtc_vblank_on(&mxsfb->pipe.crtc);
pm_runtime_get_sync(drm->dev);
drm_panel_prepare(mxsfb->panel);
mxsfb_crtc_enable(mxsfb);
drm_panel_enable(mxsfb->panel);
pm_runtime_get_sync(mxsfb->dev);
}
static void mxsfb_pipe_disable(struct drm_simple_display_pipe *pipe)
{
struct mxsfb_drm_private *mxsfb = drm_pipe_to_mxsfb_drm_private(pipe);
struct drm_crtc *crtc = &pipe->crtc;
struct drm_device *drm = pipe->plane.dev;
spin_lock_irq(&crtc->dev->event_lock);
if (crtc->state->event) {
@ -212,7 +213,7 @@ static void mxsfb_pipe_disable(struct drm_simple_display_pipe *pipe)
drm_panel_disable(mxsfb->panel);
mxsfb_crtc_disable(mxsfb);
drm_panel_unprepare(mxsfb->panel);
pm_runtime_put_sync(mxsfb->dev);
pm_runtime_put_sync(drm->dev);
if (mxsfb->connector != &mxsfb->panel_connector)
mxsfb->connector = NULL;