redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

dmaengine: ipu: use return value of request_irq

Browse source 
Commit - 653e67f7e5: "dmaengine: inherit debug settings from the subsystem
for subdirectories" introduced debug option for subdirectories too
This exposed issue with ipu driver not using return value

For now just warn users about it

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
Vinod Koul 2014-07-25 15:39:50 +05:30
parent e2f9922ad4
commit 37a746aaf5
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/dma/ipu/ipu_idmac.c
View file

@ -1532,11 +1532,17 @@ static int idmac_alloc_chan_resources(struct dma_chan *chan)
#ifdef DEBUG #ifdef DEBUG
if (chan->chan_id == IDMAC_IC_7) { if (chan->chan_id == IDMAC_IC_7) {
ic_sof = ipu_irq_map(69); ic_sof = ipu_irq_map(69);
if (ic_sof > 0) if (ic_sof > 0) {
request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan); ret = request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan);
if (ret)
dev_err(&chan->dev->device, "request irq failed for IC SOF");
}
ic_eof = ipu_irq_map(70); ic_eof = ipu_irq_map(70);
if (ic_eof > 0) if (ic_eof > 0) {
request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan); ret = request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan);
if (ret)
dev_err(&chan->dev->device, "request irq failed for IC EOF");
}
} }
#endif #endif