redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

staging:iio:fix using iio_priv or iio_dev after iio_unregister_device

Browse source 
This includes calling iio_free_device as that should only be called
before the device has been registered.

Also one case of iio_free_device being called on a registered device.

This has been pulled out of the reworking attributes patch.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Jonathan Cameron 2011-08-30 12:41:18 +01:00 committed by Greg Kroah-Hartman
parent acc131fa9f
commit 3e39440789
15 changed files with 10 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/iio/accel/adis16201_core.c
View file

@ -538,8 +538,8 @@ static int adis16201_remove(struct spi_device *spi)
adis16201_remove_trigger(indio_dev);
iio_ring_buffer_unregister(indio_dev);
iio_device_unregister(indio_dev);
adis16201_unconfigure_ring(indio_dev);
iio_device_unregister(indio_dev);
return 0;
}

2
drivers/staging/iio/accel/adis16203_core.c
View file

@ -492,8 +492,8 @@ static int adis16203_remove(struct spi_device *spi)
adis16203_remove_trigger(indio_dev);
iio_ring_buffer_unregister(indio_dev);
iio_device_unregister(indio_dev);
adis16203_unconfigure_ring(indio_dev);
iio_device_unregister(indio_dev);
return 0;
}

2
drivers/staging/iio/accel/adis16204_core.c
View file

@ -567,8 +567,8 @@ static int adis16204_remove(struct spi_device *spi)
adis16204_remove_trigger(indio_dev);
iio_ring_buffer_unregister(indio_dev);
iio_device_unregister(indio_dev);
adis16204_unconfigure_ring(indio_dev);
iio_device_unregister(indio_dev);
return 0;
}

2
drivers/staging/iio/accel/adis16209_core.c
View file

@ -542,8 +542,8 @@ static int adis16209_remove(struct spi_device *spi)
adis16209_remove_trigger(indio_dev);
iio_ring_buffer_unregister(indio_dev);
iio_device_unregister(indio_dev);
adis16209_unconfigure_ring(indio_dev);
iio_device_unregister(indio_dev);
return 0;
}

2
drivers/staging/iio/accel/adis16240_core.c
View file

@ -596,8 +596,8 @@ static int adis16240_remove(struct spi_device *spi)
adis16240_remove_trigger(indio_dev);
iio_ring_buffer_unregister(indio_dev);
iio_device_unregister(indio_dev);
adis16240_unconfigure_ring(indio_dev);
iio_device_unregister(indio_dev);
return 0;
}

1
drivers/staging/iio/adc/ad7291.c
View file

@ -857,7 +857,6 @@ static int __devexit ad7291_remove(struct i2c_client *client)
if (client->irq)
free_irq(client->irq, indio_dev);
iio_device_unregister(indio_dev);
iio_free_device(indio_dev);
return 0;
}

1
drivers/staging/iio/adc/ad7314.c
View file

@ -240,7 +240,6 @@ static int __devexit ad7314_remove(struct spi_device *spi_dev)
dev_set_drvdata(&spi_dev->dev, NULL);
iio_device_unregister(indio_dev);
iio_free_device(indio_dev);
return 0;
}

1
drivers/staging/iio/adc/ad7816.c
View file

@ -443,7 +443,6 @@ static int __devexit ad7816_remove(struct spi_device *spi_dev)
gpio_free(chip->convert_pin);
gpio_free(chip->rdwr_pin);
iio_device_unregister(indio_dev);
iio_free_device(indio_dev);
return 0;
}

1
drivers/staging/iio/adc/adt7310.c
View file

@ -864,7 +864,6 @@ static int __devexit adt7310_remove(struct spi_device *spi_dev)
if (spi_dev->irq)
free_irq(spi_dev->irq, indio_dev);
iio_device_unregister(indio_dev);
iio_free_device(indio_dev);
return 0;
}

1
drivers/staging/iio/adc/adt75.c
View file

@ -618,7 +618,6 @@ static int __devexit adt75_remove(struct i2c_client *client)
if (client->irq)
free_irq(client->irq, indio_dev);
iio_device_unregister(indio_dev);
iio_free_device(indio_dev);
return 0;
}

1
drivers/staging/iio/addac/adt7316.c
View file

@ -2225,7 +2225,6 @@ int __devexit adt7316_remove(struct device *dev)
if (chip->bus.irq)
free_irq(chip->bus.irq, indio_dev);
iio_device_unregister(indio_dev);
iio_free_device(indio_dev);
return 0;
}

6
drivers/staging/iio/dac/ad5624r_spi.c
View file

@ -262,12 +262,12 @@ static int __devinit ad5624r_probe(struct spi_device *spi)
indio_dev->info = &ad5624r_info;
indio_dev->modes = INDIO_DIRECT_MODE;
ret = iio_device_register(indio_dev);
ret = ad5624r_spi_write(spi, AD5624R_CMD_INTERNAL_REFER_SETUP, 0,
!!voltage_uv, 16);
if (ret)
goto error_free_dev;
ret = ad5624r_spi_write(spi, AD5624R_CMD_INTERNAL_REFER_SETUP, 0,
!!voltage_uv, 16);
ret = iio_device_register(indio_dev);
if (ret)
goto error_free_dev;

2
drivers/staging/iio/gyro/adis16260_core.c
View file

@ -677,8 +677,8 @@ static int adis16260_remove(struct spi_device *spi)
adis16260_remove_trigger(indio_dev);
iio_ring_buffer_unregister(indio_dev);
iio_device_unregister(indio_dev);
adis16260_unconfigure_ring(indio_dev);
iio_device_unregister(indio_dev);
err_ret:
return ret;

1
drivers/staging/iio/magnetometer/ak8975.c
View file

@ -547,7 +547,6 @@ static int ak8975_remove(struct i2c_client *client)
int eoc_gpio = data->eoc_gpio;
iio_device_unregister(indio_dev);
iio_free_device(indio_dev);
if (eoc_gpio)
gpio_free(eoc_gpio);

2
drivers/staging/iio/resolver/ad2s1210.c
View file

@ -784,8 +784,8 @@ static int __devexit ad2s1210_remove(struct spi_device *spi)
{
struct iio_dev *indio_dev = spi_get_drvdata(spi);
struct ad2s1210_state *st = iio_priv(indio_dev);
iio_device_unregister(indio_dev);
ad2s1210_free_gpios(st);
iio_device_unregister(indio_dev);
return 0;
}