redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

MLK-20324 gpu: imx: dpu: tcon: Initialize tmp_m in tcon_cfg_videomode() 

The video mode tmp_m, as a local variable in tcon_cfg_videomode(),
is uninitialized and used to store a copy instance from the real
video mode.  tcon_cfg_videomode() would change the timing of it if
side_by_side mode is enabled.  Theoretically, there should be no
problem even if we don't initialize tmp_m.  However, coverity
reports that tmp_m is an uninitialized scalar variable when the copy
is being done(CID 5233067: Uninitialized scalar variable (UNINIT)).
This patch fixes the issue reported by coverity.

Signed-off-by: Liu Ying <victor.liu@nxp.com>
pull/10/head
Liu Ying 2018-11-12 14:44:17 +08:00
parent 95bc1eb150
commit 3ec344d6fa
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/imx/dpu/dpu-tcon.c
View File

@ -128,7 +128,7 @@ EXPORT_SYMBOL_GPL(tcon_set_operation_mode);
void tcon_cfg_videomode(struct dpu_tcon *tcon,
struct drm_display_mode *m, bool side_by_side)
{
struct drm_display_mode tmp_m;
struct drm_display_mode tmp_m = { 0 };
struct dpu_soc *dpu = tcon->dpu;
const struct dpu_devtype *devtype = dpu->devtype;
u32 val;