redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

net: l2tp: fix negative assignment to unsigned int

Browse source 
recv_seq, send_seq and lns_mode mode are all defined as
unsigned int foo:1;

Signed-off-by: Asbjoern Sloth Toennesen <asbjorn@asbjorn.st>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Asbjørn Sloth Tønnesen 2016-11-07 20:39:28 +00:00 committed by David S. Miller
parent 57ceb8611d
commit 3f9b9770b4
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/l2tp/l2tp_core.c
View file

@ -715,7 +715,7 @@ void l2tp_recv_common(struct l2tp_session *session, struct sk_buff *skb,
l2tp_info(session, L2TP_MSG_SEQ, l2tp_info(session, L2TP_MSG_SEQ,
"%s: requested to enable seq numbers by LNS\n", "%s: requested to enable seq numbers by LNS\n",
session->name); session->name);
session->send_seq = -1; session->send_seq = 1;
l2tp_session_set_header_len(session, tunnel->version); l2tp_session_set_header_len(session, tunnel->version);
} }
} else { } else {

6
net/l2tp/l2tp_ppp.c
View file

@ -1272,7 +1272,7 @@ static int pppol2tp_session_setsockopt(struct sock *sk,
err = -EINVAL; err = -EINVAL;
break; break;
} }
session->recv_seq = val ? -1 : 0; session->recv_seq = !!val;
l2tp_info(session, PPPOL2TP_MSG_CONTROL, l2tp_info(session, PPPOL2TP_MSG_CONTROL,
"%s: set recv_seq=%d\n", "%s: set recv_seq=%d\n",
session->name, session->recv_seq); session->name, session->recv_seq);
@ -1283,7 +1283,7 @@ static int pppol2tp_session_setsockopt(struct sock *sk,
err = -EINVAL; err = -EINVAL;
break; break;
} }
session->send_seq = val ? -1 : 0; session->send_seq = !!val;
{ {
struct sock *ssk = ps->sock; struct sock *ssk = ps->sock;
struct pppox_sock *po = pppox_sk(ssk); struct pppox_sock *po = pppox_sk(ssk);
@ -1301,7 +1301,7 @@ static int pppol2tp_session_setsockopt(struct sock *sk,
err = -EINVAL; err = -EINVAL;
break; break;
} }
session->lns_mode = val ? -1 : 0; session->lns_mode = !!val;
l2tp_info(session, PPPOL2TP_MSG_CONTROL, l2tp_info(session, PPPOL2TP_MSG_CONTROL,
"%s: set lns_mode=%d\n", "%s: set lns_mode=%d\n",
session->name, session->lns_mode); session->name, session->lns_mode);