scsi: ibmvscsis: Fix a stringop-overflow warning
[ Upstream commit d792d4c4fc
]
There's currently a warning about string overflow with strncat:
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified
bound 64 equals destination size [-Werror=stringop-overflow=]
strncat(vscsi->eye, vdev->name, MAX_EYE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Switch to a single snprintf instead of a strcpy + strcat to handle this
cleanly.
Signed-off-by: Laura Abbott <labbott@redhat.com>
Suggested-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
pull/10/head
parent
89450e431a
commit
40e49c1553
|
@ -3465,8 +3465,7 @@ static int ibmvscsis_probe(struct vio_dev *vdev,
|
|||
vscsi->dds.window[LOCAL].liobn,
|
||||
vscsi->dds.window[REMOTE].liobn);
|
||||
|
||||
strcpy(vscsi->eye, "VSCSI ");
|
||||
strncat(vscsi->eye, vdev->name, MAX_EYE);
|
||||
snprintf(vscsi->eye, sizeof(vscsi->eye), "VSCSI %s", vdev->name);
|
||||
|
||||
vscsi->dds.unit_id = vdev->unit_address;
|
||||
strncpy(vscsi->dds.partition_name, partition_name,
|
||||
|
|
Loading…
Reference in New Issue