redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

KEYS: Delete an error message for a failed memory allocation in get_derived_key() 

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
zero-colors
Markus Elfring 2017-06-08 14:47:56 +01:00 committed by James Morris
parent 4e880168e9
commit 41f1c53e0d
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
security/keys/encrypted-keys/encrypted.c
View File

@ -385,10 +385,9 @@ static int get_derived_key(u8 *derived_key, enum derived_key_type key_type,
derived_buf_len = HASH_SIZE;
derived_buf = kzalloc(derived_buf_len, GFP_KERNEL);
if (!derived_buf) {
pr_err("encrypted_key: out of memory\n");
if (!derived_buf)
return -ENOMEM;
}
if (key_type)
strcpy(derived_buf, "AUTH_KEY");
else