team: Fix double free in error path
[ Upstream commitpull/10/headcbcc607e18
] The __send_and_alloc_skb() receives a skb ptr as a parameter but in case it fails the skb is not valid: - Send failed and released the skb internally. - Allocation failed. The current code tries to release the skb in case of failure which causes redundant freeing. Fixes:9b00cf2d10
("team: implement multipart netlink messages for options transfers") Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
parent
329f4710f8
commit
43d8f3c5d3
|
@ -2394,7 +2394,7 @@ send_done:
|
|||
if (!nlh) {
|
||||
err = __send_and_alloc_skb(&skb, team, portid, send_func);
|
||||
if (err)
|
||||
goto errout;
|
||||
return err;
|
||||
goto send_done;
|
||||
}
|
||||
|
||||
|
@ -2680,7 +2680,7 @@ send_done:
|
|||
if (!nlh) {
|
||||
err = __send_and_alloc_skb(&skb, team, portid, send_func);
|
||||
if (err)
|
||||
goto errout;
|
||||
return err;
|
||||
goto send_done;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue