Input: synaptics-rmi4 - unlock on error
commit792f497b22
upstream. We should unlock before returning on this error path. Fixes:3a762dbd53
('[media] Input: synaptics-rmi4 - add support for F54 diagnostics') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
584cb7dd15
commit
447433e5f8
|
@ -200,7 +200,7 @@ static int rmi_f54_request_report(struct rmi_function *fn, u8 report_type)
|
|||
|
||||
error = rmi_write(rmi_dev, fn->fd.command_base_addr, F54_GET_REPORT);
|
||||
if (error < 0)
|
||||
return error;
|
||||
goto unlock;
|
||||
|
||||
init_completion(&f54->cmd_done);
|
||||
|
||||
|
@ -209,9 +209,10 @@ static int rmi_f54_request_report(struct rmi_function *fn, u8 report_type)
|
|||
|
||||
queue_delayed_work(f54->workqueue, &f54->work, 0);
|
||||
|
||||
unlock:
|
||||
mutex_unlock(&f54->data_mutex);
|
||||
|
||||
return 0;
|
||||
return error;
|
||||
}
|
||||
|
||||
static size_t rmi_f54_get_report_size(struct f54_data *f54)
|
||||
|
|
Loading…
Reference in a new issue