redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

netrom: Kill spurious NULL'ing of sk->sk_socket. 

In nr_release(), one code path calls sock_orphan() which
will NULL out sk->sk_socket already.

In the other case, handling states other than NR_STATE_{0,1,2,3},
seems to not be possible other than due to bugs.  Even for an
uninitialized nr->state value, that would be zero or NR_STATE_0.
It might be wise to stick a WARN_ON() here.

Signed-off-by: David S. Miller <davem@davemloft.net>
wifi-calibration
David S. Miller 2008-06-17 03:19:58 -07:00
parent c751e4f8b3
commit 48c5732f4a
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/netrom/af_netrom.c
View File

@ -536,11 +536,9 @@ static int nr_release(struct socket *sock)
sk->sk_state_change(sk);
sock_orphan(sk);
sock_set_flag(sk, SOCK_DESTROY);
sk->sk_socket = NULL;
break;
default:
sk->sk_socket = NULL;
break;
}