kref: Implement kref_get_unless_zero v3
This function is intended to simplify locking around refcounting for objects that can be looked up from a lookup structure, and which are removed from that lookup structure in the object destructor. Operations on such objects require at least a read lock around lookup + kref_get, and a write lock around kref_put + remove from lookup structure. Furthermore, RCU implementations become extremely tricky. With a lookup followed by a kref_get_unless_zero *with return value check* locking in the kref_put path can be deferred to the actual removal from the lookup structure and RCU lookups become trivial. v2: Formatting fixes. v3: Invert the return value. Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com> Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
parent
d714455619
commit
4b20db3de8
|
@ -111,4 +111,25 @@ static inline int kref_put_mutex(struct kref *kref,
|
||||||
}
|
}
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* kref_get_unless_zero - Increment refcount for object unless it is zero.
|
||||||
|
* @kref: object.
|
||||||
|
*
|
||||||
|
* Return non-zero if the increment succeeded. Otherwise return 0.
|
||||||
|
*
|
||||||
|
* This function is intended to simplify locking around refcounting for
|
||||||
|
* objects that can be looked up from a lookup structure, and which are
|
||||||
|
* removed from that lookup structure in the object destructor.
|
||||||
|
* Operations on such objects require at least a read lock around
|
||||||
|
* lookup + kref_get, and a write lock around kref_put + remove from lookup
|
||||||
|
* structure. Furthermore, RCU implementations become extremely tricky.
|
||||||
|
* With a lookup followed by a kref_get_unless_zero *with return value check*
|
||||||
|
* locking in the kref_put path can be deferred to the actual removal from
|
||||||
|
* the lookup structure and RCU lookups become trivial.
|
||||||
|
*/
|
||||||
|
static inline int __must_check kref_get_unless_zero(struct kref *kref)
|
||||||
|
{
|
||||||
|
return atomic_add_unless(&kref->refcount, 1, 0);
|
||||||
|
}
|
||||||
#endif /* _KREF_H_ */
|
#endif /* _KREF_H_ */
|
||||||
|
|
Loading…
Reference in a new issue