redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

HID: picoLCD: Deletion of unnecessary checks before three function calls 

The functions backlight_device_unregister(), lcd_device_unregister() and
rc_unregister_device() test whether their argument is NULL and then
return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
steinar/wifi_calib_4_9_kernel
Markus Elfring 2014-11-19 18:30:22 +01:00 committed by Jiri Kosina
parent 67db8a8086
commit 4b8a826208
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/hid/hid-picolcd_backlight.c
View File

@ -94,8 +94,7 @@ void picolcd_exit_backlight(struct picolcd_data *data)
struct backlight_device *bdev = data->backlight;
data->backlight = NULL;
if (bdev)
backlight_device_unregister(bdev);
backlight_device_unregister(bdev);
}
int picolcd_resume_backlight(struct picolcd_data *data)

3
drivers/hid/hid-picolcd_cir.c
View File

@ -145,7 +145,6 @@ void picolcd_exit_cir(struct picolcd_data *data)
struct rc_dev *rdev = data->rc_dev;
data->rc_dev = NULL;
if (rdev)
rc_unregister_device(rdev);
rc_unregister_device(rdev);
}

3
drivers/hid/hid-picolcd_lcd.c
View File

@ -92,8 +92,7 @@ void picolcd_exit_lcd(struct picolcd_data *data)
struct lcd_device *ldev = data->lcd;
data->lcd = NULL;
if (ldev)
lcd_device_unregister(ldev);
lcd_device_unregister(ldev);
}
int picolcd_resume_lcd(struct picolcd_data *data)