redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

omapfb: panel-sharp-ls037v7dw01: fix check of gpio_to_desc() return value

Browse source 
The change fixes a check of gpio_to_desc() return value, the function
returns either a valid pointer to struct gpio_desc or NULL, this makes
IS_ERR() check invalid and may lead to a NULL pointer dereference in
runtime.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Vladimir Zapolskiy 2016-03-23 00:51:54 +02:00 committed by Tomi Valkeinen
parent f36fdacc5f
commit 4dacad6151
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c
View file

@ -200,20 +200,16 @@ static struct omap_dss_driver sharp_ls_ops = {
static int sharp_ls_get_gpio(struct device *dev, int gpio, unsigned long flags,
char *desc, struct gpio_desc **gpiod)
{
struct gpio_desc *gd;
int r;
*gpiod = NULL;
r = devm_gpio_request_one(dev, gpio, flags, desc);
if (r)
if (r) {
*gpiod = NULL;
return r == -ENOENT ? 0 : r;
}
gd = gpio_to_desc(gpio);
if (IS_ERR(gd))
return PTR_ERR(gd) == -ENOENT ? 0 : PTR_ERR(gd);
*gpiod = gpio_to_desc(gpio);
*gpiod = gd;
return 0;
}