redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

mptfusion: remove redundant kfree checks 

Fixes the following smatch warnings:

  drivers/message/fusion/mptfc.c:529 mptfc_target_destroy() info:
    redundant null check on starget->hostdata calling kfree()

  drivers/message/fusion/mptspi.c:465 mptspi_target_destroy() info:
    redundant null check on starget->hostdata calling kfree()

Signed-off-by: Joe Lawrence <joe.lawrence@stratus.com>
Acked-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
wifi-calibration
Joe Lawrence 2014-06-25 17:06:02 -04:00 committed by Christoph Hellwig
parent 5767d25f0d
commit 5074b1b60e
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/message/fusion/mptfc.c
View File

@ -525,8 +525,7 @@ mptfc_target_destroy(struct scsi_target *starget)
if (ri) /* better be! */
ri->starget = NULL;
}
if (starget->hostdata)
kfree(starget->hostdata);
kfree(starget->hostdata);
starget->hostdata = NULL;
}

3
drivers/message/fusion/mptspi.c
View File

@ -461,8 +461,7 @@ static int mptspi_target_alloc(struct scsi_target *starget)
static void
mptspi_target_destroy(struct scsi_target *starget)
{
if (starget->hostdata)
kfree(starget->hostdata);
kfree(starget->hostdata);
starget->hostdata = NULL;
}