redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

addrconf: always initialize sysctl table data

Browse source 
When sysctl performs restrict writes, it allows to write from
a middle position of a sysctl file, which requires us to initialize
the table data before calling proc_dostring() for the write case.

Fixes: 3d1bec9932 ("ipv6: introduce secret_stable to ipv6_devconf")
Reported-by: Sasha Levin <sasha.levin@oracle.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Tested-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
WANG Cong 2015-12-21 10:55:45 -08:00 committed by David S. Miller
parent 024f35c552
commit 5449a5ca9b
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
net/ipv6/addrconf.c
View file

@ -5369,13 +5369,10 @@ static int addrconf_sysctl_stable_secret(struct ctl_table *ctl, int write,
goto out; goto out;
} }
if (!write) { err = snprintf(str, sizeof(str), "%pI6", &secret->secret);
err = snprintf(str, sizeof(str), "%pI6", if (err >= sizeof(str)) {
&secret->secret); err = -EIO;
if (err >= sizeof(str)) { goto out;
err = -EIO;
goto out;
}
} }
err = proc_dostring(&lctl, write, buffer, lenp, ppos); err = proc_dostring(&lctl, write, buffer, lenp, ppos);