redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

lightnvm: pblk: remove some unnecessary NULL checks

Browse source 
Smatch complains that flush_workqueue() dereferences the work queue
pointer but then we check if it's NULL on the next line when it's too
late.  These NULL checks can be removed because the module won't load if
we can't allocate the work queues.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Dan Carpenter 2018-03-30 00:05:23 +02:00 committed by Jens Axboe
parent 9156f360a7
commit 5565b0ca50
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/lightnvm/pblk-gc.c
View file

@ -664,12 +664,10 @@ void pblk_gc_exit(struct pblk *pblk)
kthread_stop(gc->gc_reader_ts); kthread_stop(gc->gc_reader_ts);
flush_workqueue(gc->gc_reader_wq); flush_workqueue(gc->gc_reader_wq);
if (gc->gc_reader_wq) destroy_workqueue(gc->gc_reader_wq);
destroy_workqueue(gc->gc_reader_wq);
flush_workqueue(gc->gc_line_reader_wq); flush_workqueue(gc->gc_line_reader_wq);
if (gc->gc_line_reader_wq) destroy_workqueue(gc->gc_line_reader_wq);
destroy_workqueue(gc->gc_line_reader_wq);
if (gc->gc_writer_ts) if (gc->gc_writer_ts)
kthread_stop(gc->gc_writer_ts); kthread_stop(gc->gc_writer_ts);