redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

of_pci: use of_property_read_u32() 

of_get_pci_domain_nr() somehow didn't use of_property_read_u32() though it
was long available, basically open-coding it. Using the modern DT API saves
several LoCs/bytes and also adds some prop sanity checks as a bonus...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Rob Herring <robh@kernel.org>
zero-colors
Sergei Shtylyov 2017-07-23 22:41:45 +03:00 committed by Rob Herring
parent b0d9d92f9c
commit 56134e3c64
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/of/of_pci.c
View File

@ -105,17 +105,14 @@ EXPORT_SYMBOL_GPL(of_pci_parse_bus_range);
*/
int of_get_pci_domain_nr(struct device_node *node)
{
const __be32 *value;
int len;
u16 domain;
u32 domain;
int error;
value = of_get_property(node, "linux,pci-domain", &len);
if (!value || len < sizeof(*value))
return -EINVAL;
error = of_property_read_u32(node, "linux,pci-domain", &domain);
if (error)
return error;
domain = (u16)be32_to_cpup(value);
return domain;
return (u16)domain;
}
EXPORT_SYMBOL_GPL(of_get_pci_domain_nr);