redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

mtd: sm_ftl: Staticize local symbols

Browse source 
These local symbols are used only in this file.
Fix the following sparse warnings:

drivers/mtd/sm_ftl.c:25:25: warning: symbol 'cache_flush_workqueue' was not declared. Should it be static?
drivers/mtd/sm_ftl.c:44:9: warning: symbol 'sm_attr_show' was not declared. Should it be static?
drivers/mtd/sm_ftl.c:57:24: warning: symbol 'sm_create_sysfs_attributes' was not declared. Should it be static?
drivers/mtd/sm_ftl.c:110:6: warning: symbol 'sm_delete_sysfs_attributes' was not declared. Should it be static?
drivers/mtd/sm_ftl.c:574:5: warning: symbol 'sm_get_media_info' was not declared. Should it be static?
drivers/mtd/sm_ftl.c:881:17: warning: symbol 'sm_get_zone' was not declared. Should it be static?
drivers/mtd/sm_ftl.c:902:6: warning: symbol 'sm_cache_init' was not declared. Should it be static?
drivers/mtd/sm_ftl.c:912:6: warning: symbol 'sm_cache_put' was not declared. Should it be static?
drivers/mtd/sm_ftl.c:920:5: warning: symbol 'sm_cache_get' was not declared. Should it be static?
drivers/mtd/sm_ftl.c:931:5: warning: symbol 'sm_cache_flush' was not declared. Should it be static?

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
This commit is contained in:
Jingoo Han 2013-08-07 16:10:21 +09:00 committed by David Woodhouse
parent a3d7ee9ff8
commit 582b2ffcaa
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
drivers/mtd/sm_ftl.c
View file

@ -22,7 +22,7 @@
struct workqueue_struct *cache_flush_workqueue; static struct workqueue_struct *cache_flush_workqueue;
static int cache_timeout = 1000; static int cache_timeout = 1000;
module_param(cache_timeout, int, S_IRUGO); module_param(cache_timeout, int, S_IRUGO);
@ -41,7 +41,7 @@ struct sm_sysfs_attribute {
int len; int len;
}; };
ssize_t sm_attr_show(struct device *dev, struct device_attribute *attr, static ssize_t sm_attr_show(struct device *dev, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct sm_sysfs_attribute *sm_attr = struct sm_sysfs_attribute *sm_attr =
@ -54,7 +54,7 @@ ssize_t sm_attr_show(struct device *dev, struct device_attribute *attr,
#define NUM_ATTRIBUTES 1 #define NUM_ATTRIBUTES 1
#define SM_CIS_VENDOR_OFFSET 0x59 #define SM_CIS_VENDOR_OFFSET 0x59
struct attribute_group *sm_create_sysfs_attributes(struct sm_ftl *ftl) static struct attribute_group *sm_create_sysfs_attributes(struct sm_ftl *ftl)
{ {
struct attribute_group *attr_group; struct attribute_group *attr_group;
struct attribute **attributes; struct attribute **attributes;
@ -107,7 +107,7 @@ error1:
return NULL; return NULL;
} }
void sm_delete_sysfs_attributes(struct sm_ftl *ftl) static void sm_delete_sysfs_attributes(struct sm_ftl *ftl)
{ {
struct attribute **attributes = ftl->disk_attributes->attrs; struct attribute **attributes = ftl->disk_attributes->attrs;
int i; int i;
@ -571,7 +571,7 @@ static const uint8_t cis_signature[] = {
}; };
/* Find out media parameters. /* Find out media parameters.
* This ideally has to be based on nand id, but for now device size is enough */ * This ideally has to be based on nand id, but for now device size is enough */
int sm_get_media_info(struct sm_ftl *ftl, struct mtd_info *mtd) static int sm_get_media_info(struct sm_ftl *ftl, struct mtd_info *mtd)
{ {
int i; int i;
int size_in_megs = mtd->size / (1024 * 1024); int size_in_megs = mtd->size / (1024 * 1024);
@ -878,7 +878,7 @@ static int sm_init_zone(struct sm_ftl *ftl, int zone_num)
} }
/* Get and automatically initialize an FTL mapping for one zone */ /* Get and automatically initialize an FTL mapping for one zone */
struct ftl_zone *sm_get_zone(struct sm_ftl *ftl, int zone_num) static struct ftl_zone *sm_get_zone(struct sm_ftl *ftl, int zone_num)
{ {
struct ftl_zone *zone; struct ftl_zone *zone;
int error; int error;
@ -899,7 +899,7 @@ struct ftl_zone *sm_get_zone(struct sm_ftl *ftl, int zone_num)
/* ----------------- cache handling ------------------------------------------*/ /* ----------------- cache handling ------------------------------------------*/
/* Initialize the one block cache */ /* Initialize the one block cache */
void sm_cache_init(struct sm_ftl *ftl) static void sm_cache_init(struct sm_ftl *ftl)
{ {
ftl->cache_data_invalid_bitmap = 0xFFFFFFFF; ftl->cache_data_invalid_bitmap = 0xFFFFFFFF;
ftl->cache_clean = 1; ftl->cache_clean = 1;
@ -909,7 +909,7 @@ void sm_cache_init(struct sm_ftl *ftl)
} }
/* Put sector in one block cache */ /* Put sector in one block cache */
void sm_cache_put(struct sm_ftl *ftl, char *buffer, int boffset) static void sm_cache_put(struct sm_ftl *ftl, char *buffer, int boffset)
{ {
memcpy(ftl->cache_data + boffset, buffer, SM_SECTOR_SIZE); memcpy(ftl->cache_data + boffset, buffer, SM_SECTOR_SIZE);
clear_bit(boffset / SM_SECTOR_SIZE, &ftl->cache_data_invalid_bitmap); clear_bit(boffset / SM_SECTOR_SIZE, &ftl->cache_data_invalid_bitmap);
@ -917,7 +917,7 @@ void sm_cache_put(struct sm_ftl *ftl, char *buffer, int boffset)
} }
/* Read a sector from the cache */ /* Read a sector from the cache */
int sm_cache_get(struct sm_ftl *ftl, char *buffer, int boffset) static int sm_cache_get(struct sm_ftl *ftl, char *buffer, int boffset)
{ {
if (test_bit(boffset / SM_SECTOR_SIZE, if (test_bit(boffset / SM_SECTOR_SIZE,
&ftl->cache_data_invalid_bitmap)) &ftl->cache_data_invalid_bitmap))
@ -928,7 +928,7 @@ int sm_cache_get(struct sm_ftl *ftl, char *buffer, int boffset)
} }
/* Write the cache to hardware */ /* Write the cache to hardware */
int sm_cache_flush(struct sm_ftl *ftl) static int sm_cache_flush(struct sm_ftl *ftl)
{ {
struct ftl_zone *zone; struct ftl_zone *zone;