redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

rtc: sh: mark PM functions as unused 

The sh_rtc_set_irq_wake() function is only called from the suspend/resume handlers
that may be hidden, causing a harmless warning:

drivers/rtc/rtc-sh.c:724:13: error: 'sh_rtc_set_irq_wake' defined but not used [-Werror=unused-function]
 static void sh_rtc_set_irq_wake(struct device *dev, int enabled)

The most reliable way to avoid the warning is to remove the existing #ifdef
and mark the two functions as __maybe_unused so the compiler can silently
drop all three when there is no reference.

Fixes: dab5aec64b ("rtc: sh: add support for rza series")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
zero-colors
Arnd Bergmann 2017-04-19 19:52:43 +02:00 committed by Alexandre Belloni
parent e73ef755fb
commit 5d05e81516
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/rtc/rtc-sh.c
View File

@ -734,8 +734,7 @@ static void sh_rtc_set_irq_wake(struct device *dev, int enabled)
} }
} }
#ifdef CONFIG_PM_SLEEP static int __maybe_unused sh_rtc_suspend(struct device *dev)
static int sh_rtc_suspend(struct device *dev)
{ {
if (device_may_wakeup(dev)) if (device_may_wakeup(dev))
sh_rtc_set_irq_wake(dev, 1); sh_rtc_set_irq_wake(dev, 1);
@ -743,14 +742,13 @@ static int sh_rtc_suspend(struct device *dev)
return 0; return 0;
} }
static int sh_rtc_resume(struct device *dev) static int __maybe_unused sh_rtc_resume(struct device *dev)
{ {
if (device_may_wakeup(dev)) if (device_may_wakeup(dev))
sh_rtc_set_irq_wake(dev, 0); sh_rtc_set_irq_wake(dev, 0);
return 0; return 0;
} }
#endif
static SIMPLE_DEV_PM_OPS(sh_rtc_pm_ops, sh_rtc_suspend, sh_rtc_resume); static SIMPLE_DEV_PM_OPS(sh_rtc_pm_ops, sh_rtc_suspend, sh_rtc_resume);