[PATCH] tlclk: fix platform_device_register_simple() error check
The return value of platform_device_register_simple() should be checked by IS_ERR(). This patch also fix misc_register() error case. Because misc_register() returns error code. Cc: Sebastien Bouchard <sebastien.bouchard@ca.kontron.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
753ca4f312
commit
5e66b0b5f1
|
@ -792,15 +792,14 @@ static int __init tlclk_init(void)
|
|||
ret = misc_register(&tlclk_miscdev);
|
||||
if (ret < 0) {
|
||||
printk(KERN_ERR "tlclk: misc_register returns %d.\n", ret);
|
||||
ret = -EBUSY;
|
||||
goto out3;
|
||||
}
|
||||
|
||||
tlclk_device = platform_device_register_simple("telco_clock",
|
||||
-1, NULL, 0);
|
||||
if (!tlclk_device) {
|
||||
if (IS_ERR(tlclk_device)) {
|
||||
printk(KERN_ERR "tlclk: platform_device_register failed.\n");
|
||||
ret = -EBUSY;
|
||||
ret = PTR_ERR(tlclk_device);
|
||||
goto out4;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue