tools: hv: fix checks for origin of netlink message in hv_vss_daemon
Similar to what commit 95a69adab9
("tools:
hv: Netlink source address validation allows DoS") does in
hv_kvp_daemon, improve checks for origin of netlink connector message.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
eb8905b8ff
commit
5edf5ee42a
|
@ -186,13 +186,19 @@ int main(void)
|
||||||
len = recvfrom(fd, vss_recv_buffer, sizeof(vss_recv_buffer), 0,
|
len = recvfrom(fd, vss_recv_buffer, sizeof(vss_recv_buffer), 0,
|
||||||
addr_p, &addr_l);
|
addr_p, &addr_l);
|
||||||
|
|
||||||
if (len < 0 || addr.nl_pid) {
|
if (len < 0) {
|
||||||
syslog(LOG_ERR, "recvfrom failed; pid:%u error:%d %s",
|
syslog(LOG_ERR, "recvfrom failed; pid:%u error:%d %s",
|
||||||
addr.nl_pid, errno, strerror(errno));
|
addr.nl_pid, errno, strerror(errno));
|
||||||
close(fd);
|
close(fd);
|
||||||
return -1;
|
return -1;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (addr.nl_pid) {
|
||||||
|
syslog(LOG_WARNING, "Received packet from untrusted pid:%u",
|
||||||
|
addr.nl_pid);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
incoming_msg = (struct nlmsghdr *)vss_recv_buffer;
|
incoming_msg = (struct nlmsghdr *)vss_recv_buffer;
|
||||||
|
|
||||||
if (incoming_msg->nlmsg_type != NLMSG_DONE)
|
if (incoming_msg->nlmsg_type != NLMSG_DONE)
|
||||||
|
|
Loading…
Reference in a new issue