redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

misc: mic: Release reference count and memory for VOP device

Browse source 
Never directly free @dev after calling device_register(),
even if it returned an error! Always use put_device() to
give up the reference initialized.
Release allocated memory for vop device in vop_release_dev().

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Arvind Yadav 2018-03-12 17:06:52 +05:30 committed by Greg Kroah-Hartman
parent 1b723413aa
commit 5fbe9f35df
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/misc/mic/bus/vop_bus.c
View file

@ -135,7 +135,9 @@ EXPORT_SYMBOL_GPL(vop_unregister_driver);
static void vop_release_dev(struct device *d) static void vop_release_dev(struct device *d)
{ {
put_device(d); struct vop_device *dev = dev_to_vop(d);
kfree(dev);
} }
struct vop_device * struct vop_device *
@ -174,7 +176,7 @@ vop_register_device(struct device *pdev, int id,
goto free_vdev; goto free_vdev;
return vdev; return vdev;
free_vdev: free_vdev:
kfree(vdev); put_device(&vdev->dev);
return ERR_PTR(ret); return ERR_PTR(ret);
} }
EXPORT_SYMBOL_GPL(vop_register_device); EXPORT_SYMBOL_GPL(vop_register_device);