redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

netlink: Don't shift with UB on nlk->ngroups 

On i386 nlk->ngroups might be 32 or 0. Which leads to UB, resulting in
hang during boot.
Check for 0 ngroups and use (unsigned long long) as a type to shift.

Fixes: 7acf9d4237 ("netlink: Do not subscribe to non-existent groups").
Reported-by: kernel test robot <rong.a.chen@intel.com>
Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
zero-colors
Dmitry Safonov 2018-07-30 18:32:36 +01:00 committed by David S. Miller
parent af87f72e75
commit 61f4b23769
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
net/netlink/af_netlink.c
View File

@ -1008,7 +1008,11 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
if (err)
return err;
}
groups &= (1UL << nlk->ngroups) - 1;
if (nlk->ngroups == 0)
groups = 0;
else
groups &= (1ULL << nlk->ngroups) - 1;
bound = nlk->bound;
if (bound) {