redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

staging: slicoss: return early before calling request_firmware with empty firmware filename

Browse source 
when the device id doesn't match in slic_card_download_gbrcv the filename is "",
i.e an empty name, and we try calling request_firmware with that name,
actually we can just fail out at default case before even calling request_firmware

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Devendra Naga 2012-08-26 12:36:56 +05:30 committed by Greg Kroah-Hartman
parent 623c2bb2c5
commit 651d4bc7ed
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/staging/slicoss/slicoss.c
View file

@ -514,8 +514,7 @@ static int slic_card_download_gbrcv(struct adapter *adapter)
file = "slicoss/gbrcvucode.sys";
break;
default:
ASSERT(0);
break;
return -ENOENT;
}
ret = request_firmware(&fw, file, &adapter->pcidev->dev);