[PATCH] Fix memory leak in isapnp
Spotted by the Coverity checker as bug #666 akpm; there are several other `return 1;'s in there which aren't freeing `dev'. (A fix which converts this function to single-exit would be preferred..) Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> Cc: Adam Belay <ambx1@neo.rr.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
bda44e1d16
commit
656bde5728
|
@ -646,8 +646,10 @@ static int __init isapnp_create_device(struct pnp_card *card,
|
||||||
size = 0;
|
size = 0;
|
||||||
skip = 0;
|
skip = 0;
|
||||||
option = pnp_register_independent_option(dev);
|
option = pnp_register_independent_option(dev);
|
||||||
if (!option)
|
if (!option) {
|
||||||
|
kfree(dev);
|
||||||
return 1;
|
return 1;
|
||||||
|
}
|
||||||
pnp_add_card_device(card,dev);
|
pnp_add_card_device(card,dev);
|
||||||
} else {
|
} else {
|
||||||
skip = 1;
|
skip = 1;
|
||||||
|
|
Loading…
Reference in a new issue