redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

drivers/video: Convert release_resource to release_mem_region

Browse source 
Request_mem_region should be used with release_mem_region, not
release_resource.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@s exists@
expression e1,e2,e3,e4,e;
@@

*e4 = request_mem_region(e1,e2,e3)
... when != e4 = e
*release_resource(e4);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
This commit is contained in:
Julia Lawall 2011-04-22 20:11:21 +00:00 committed by Paul Mundt
parent 94cd1ae2fd
commit 683e7cdc20
2 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/video/s3c-fb.c
View file

@ -1449,8 +1449,7 @@ err_ioremap:
iounmap(sfb->regs); iounmap(sfb->regs);
err_req_region: err_req_region:
release_resource(sfb->regs_res); release_mem_region(sfb->regs_res->start, resource_size(sfb->regs_res));
kfree(sfb->regs_res);
err_clk: err_clk:
clk_disable(sfb->bus_clk); clk_disable(sfb->bus_clk);
@ -1486,8 +1485,7 @@ static int __devexit s3c_fb_remove(struct platform_device *pdev)
clk_disable(sfb->bus_clk); clk_disable(sfb->bus_clk);
clk_put(sfb->bus_clk); clk_put(sfb->bus_clk);
release_resource(sfb->regs_res); release_mem_region(sfb->regs_res->start, resource_size(sfb->regs_res));
kfree(sfb->regs_res);
kfree(sfb); kfree(sfb);

6
drivers/video/sh7760fb.c
View file

@ -551,8 +551,7 @@ out_unmap:
free_irq(par->irq, &par->vsync); free_irq(par->irq, &par->vsync);
iounmap(par->base); iounmap(par->base);
out_res: out_res:
release_resource(par->ioarea); release_mem_region(res->start, resource_size(res));
kfree(par->ioarea);
out_fb: out_fb:
framebuffer_release(info); framebuffer_release(info);
return ret; return ret;
@ -570,8 +569,7 @@ static int __devexit sh7760fb_remove(struct platform_device *dev)
if (par->irq >= 0) if (par->irq >= 0)
free_irq(par->irq, par); free_irq(par->irq, par);
iounmap(par->base); iounmap(par->base);
release_resource(par->ioarea); release_mem_region(par->ioarea->start, resource_size(par->ioarea));
kfree(par->ioarea);
framebuffer_release(info); framebuffer_release(info);
platform_set_drvdata(dev, NULL); platform_set_drvdata(dev, NULL);