redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

remoteproc: imx_rproc: fix a couple off by one bugs 

The priv->mem[] array has IMX7D_RPROC_MEM_MAX elements so the > should
be >= to avoid writing one element beyond the end of the array.

Fixes: a0ff4aa6f0 ("remoteproc: imx_rproc: add a NXP/Freescale imx_rproc driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
zero-colors
Dan Carpenter 2017-10-05 15:58:27 +03:00 committed by Bjorn Andersson
parent 2bd6bf03f4
commit 68c2d645eb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/remoteproc/imx_rproc.c
View File

@ -264,7 +264,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
if (!(att->flags & ATT_OWN))
continue;
if (b > IMX7D_RPROC_MEM_MAX)
if (b >= IMX7D_RPROC_MEM_MAX)
break;
priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
@ -296,7 +296,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
return err;
}
if (b > IMX7D_RPROC_MEM_MAX)
if (b >= IMX7D_RPROC_MEM_MAX)
break;
priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);