nvmet: fix return value check in nvmet_subsys_alloc()
In case of error, the function kstrndup() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Reviewed-by: Jay Freyensee <james_p_freyensee@linux.intel.com> Signed-off-by: Jens Axboe <axboe@fb.com>
This commit is contained in:
parent
e76debd996
commit
69555af2ce
|
@ -895,7 +895,7 @@ struct nvmet_subsys *nvmet_subsys_alloc(const char *subsysnqn,
|
||||||
subsys->type = type;
|
subsys->type = type;
|
||||||
subsys->subsysnqn = kstrndup(subsysnqn, NVMF_NQN_SIZE,
|
subsys->subsysnqn = kstrndup(subsysnqn, NVMF_NQN_SIZE,
|
||||||
GFP_KERNEL);
|
GFP_KERNEL);
|
||||||
if (IS_ERR(subsys->subsysnqn)) {
|
if (!subsys->subsysnqn) {
|
||||||
kfree(subsys);
|
kfree(subsys);
|
||||||
return NULL;
|
return NULL;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue