redonkable/remarkable-linux
redonkable/remarkable-linux
1
0
Fork 0
Code Releases Activity

ASoC: soc-core: Fix sparse warning in be32_to_cpup() call

Browse source 
Store return value of of_get_property() to a pointer of __be32 type as
device tree has big endian type. This fixes a sparse warning couple of
lines later when be32_to_cpup() is used to convert from big endian to
cpu endian.

The whole conversion is not really necessary, as we are only checking
if the value is zero or not, but I wanted to add it to remind in the
future that the data has to be converted before use. Compiler should
optimize the unnecessary operations away.

Signed-off-by: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Jyri Sarha 2015-09-17 13:13:38 +03:00 committed by Mark Brown
parent 6131084a0b
commit 6c84e5917f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sound/soc/soc-core.c
View file

@ -3296,7 +3296,7 @@ static int snd_soc_of_get_slot_mask(struct device_node *np,
unsigned int *mask)
{
u32 val;
const u32 *of_slot_mask = of_get_property(np, prop_name, &val);
const __be32 *of_slot_mask = of_get_property(np, prop_name, &val);
int i;
if (!of_slot_mask)