redonkable
/
remarkable-linux
1
0
Fork 0
Code Releases Activity

gpio: mockup: fix a potential crash when creating debugfs entries 

If we failed to create the top debugfs directory, we must not try to
create the child nodes. We currently only check if gpio_mockup_dbg_dir
is not NULL, but it can also contain an errno if debugfs is disabled
in build options. Use IS_ERR_OR_NULL() instead.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
zero-colors
Bartosz Golaszewski 2018-03-04 13:45:51 +01:00 committed by Linus Walleij
parent 3a711e0dd4
commit 6cb9215bae
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpio/gpio-mockup.c
View File

@ -314,7 +314,7 @@ static int gpio_mockup_probe(struct platform_device *pdev)
if (rv)
return rv;
if (gpio_mockup_dbg_dir)
if (!IS_ERR_OR_NULL(gpio_mockup_dbg_dir))
gpio_mockup_debugfs_setup(dev, chip);
return 0;