xfs: don't send null bp to xfs_trans_brelse()
In this case, if bp is NULL, error is set, and we send a NULL bp to xfs_trans_brelse, which will try to dereference it. Test whether we actually have a buffer before we try to free it. Coverity spotted this. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
parent
ce57bcf6b8
commit
6ee49a20c1
|
@ -2563,7 +2563,8 @@ xfs_da_get_buf(
|
|||
mapp, nmap, 0);
|
||||
error = bp ? bp->b_error : -EIO;
|
||||
if (error) {
|
||||
xfs_trans_brelse(trans, bp);
|
||||
if (bp)
|
||||
xfs_trans_brelse(trans, bp);
|
||||
goto out_free;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue